-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse glossary bib files to populate intellisense #4491
Conversation
@jlelong Sure, I got your back! Thank really much for the commit in Christmas haha 😄 I can catch up with updated extention once released and test it out. Also, I can provide three BTW as an |
Merry Chrismas @jlelong @LeoJhonSong and everyone! Yeah the implementation looks quite good to me. I think it's fine to duplicate these functions, who knows if they may diverge or not later. Feel free to merge when you think good! |
@LeoJhonSong It would definitely be helpful if you could share a real life Following your remark, I have googled for an explanation on the difference between abbreviation and acronym and came up with https://tex.meta.stackexchange.com/questions/6516/the-acronyms-and-abbreviations-tags. I am afraid it is not crystal clear but in any case, it seems equivalent from the intellisense point of view :
Let me know if the above approach complies with the typical usage of the |
This function is a duplicate of getIncludedBib from cache.ts
I have finally decided to factorize the recursive computation of included @LeoJhonSong You can try the new feature by installing the extension zipped in |
@jlelong Sure thing! Here comes symbols.bib, abbreviations.bib and Notations.bib. I will download and try the extension now😄 |
Cool, the intellisence works perfectly for me! LGTM @jlelong |
Close #4472
This PR implements the use of glossary
.bib
to populate intellisense.As glossary intellisense treats glossary and acronym entries differently, we do the same when parsing
.bib
files. Currently only@entry
entries are considered as glossary entries. Everything else is considered as an acronym entry.Hopefully I will manage to add some automatic tests but some more intensive testing from people who actually use
bib2gls
is more than welcome. @LeoJhonSong Could we count on your feedback?@James-Yu A lot of the newly added code looks very similar to the one used in
completion/completer/citation.ts
. Yet, factorizing both is not so obvious and would require to extract sub functions. I will think of it but feel free to share your thoughts if any.Btw Merry Christmas @James-Yu